-
Notifications
You must be signed in to change notification settings - Fork 535
Blog and Configuration Chapter Preview for upcoming config changes #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
132ikl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Thanks so much for working on these changes!! ❤️
|
I am pro additional blog posts, I think we still want to have the key details in the release notes but can refer to further reading. (if the blog posts encourages a few people to jump on nightly builds that would be also great) |
|
Nice work @NotTheDr01ds. I especially like the tables outlining when things happen and what config files are loaded kind of like my gist. Lots and lots of effort to get to this point. Thanks a bunch! |
|
@fdncred Thanks for the review! All changes are now pushed. @sholderbach Agreed - And I probably shouldn't have said "just" - We definitely need a short description in the release notes, with the "detailed" version being in this blog entry. Long-term, the Configuration Chapter itself is the real documentation; we just need a "transition" document in the meantime. |
|
@fdncred And thanks! Obviously the Scenarios section was ripped right from your gist and updated. I know you've had the goal for a long time of getting that into the doc itself. I meant to call that out with credit to you in the original PR ... Yes, the table is nice (and yes, a lot of work), and hopefully we can keep it up to date if and when the startup changes in the future. |
|
are we ready to land this? i figure since it says "preview" we can land it before the release. |
|
@fdncred Yes, ready to land. I'll continue to update it as we get feedback, and (if not already) it should be solid by the time 0.101 releases. Thanks! |
A blog entry with details on how to upgrade your configuration to take advantage of the recent changes. This is being made available now for ...
Rather than put all of this information in the 0.101 release notes directly, I would propose that we just have a link from the 0.101 release notes to this blog entry.
Also the new configuration chapter rewrite, based on the changes. Again, this gives an opportunity for early review and dogfooding. When 0.101 releases, I'll just remove the old
configuration.md,git mvtheconfiguration_preview.mdtoconfiguration.md, and we'll have the new chapter in place on Day 0.A few miscellaneous changes, like renaming "escapes" to "Running External System Commands" along with fixing the broken links as a result.