Skip to content

Conversation

@NotTheDr01ds
Copy link
Contributor

@NotTheDr01ds NotTheDr01ds commented Dec 3, 2024

  • A blog entry with details on how to upgrade your configuration to take advantage of the recent changes. This is being made available now for ...

    1. Users who are currently running nightlies or main
    2. Users who want to plan ahead or ask questions
    3. Early review, so that we can make any updates to it before 0.101 releases

    Rather than put all of this information in the 0.101 release notes directly, I would propose that we just have a link from the 0.101 release notes to this blog entry.

  • Also the new configuration chapter rewrite, based on the changes. Again, this gives an opportunity for early review and dogfooding. When 0.101 releases, I'll just remove the old configuration.md, git mv the configuration_preview.md to configuration.md, and we'll have the new chapter in place on Day 0.

  • A few miscellaneous changes, like renaming "escapes" to "Running External System Commands" along with fixing the broken links as a result.

@NotTheDr01ds
Copy link
Contributor Author

Also closes #1544 and #1527

Copy link
Member

@132ikl 132ikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thanks so much for working on these changes!! ❤️

@sholderbach
Copy link
Member

I am pro additional blog posts, I think we still want to have the key details in the release notes but can refer to further reading. (if the blog posts encourages a few people to jump on nightly builds that would be also great)

@fdncred
Copy link
Contributor

fdncred commented Dec 3, 2024

Nice work @NotTheDr01ds. I especially like the tables outlining when things happen and what config files are loaded kind of like my gist. Lots and lots of effort to get to this point. Thanks a bunch!

@NotTheDr01ds
Copy link
Contributor Author

@fdncred Thanks for the review! All changes are now pushed.

@sholderbach Agreed - And I probably shouldn't have said "just" - We definitely need a short description in the release notes, with the "detailed" version being in this blog entry. Long-term, the Configuration Chapter itself is the real documentation; we just need a "transition" document in the meantime.

@NotTheDr01ds
Copy link
Contributor Author

NotTheDr01ds commented Dec 3, 2024

@fdncred And thanks! Obviously the Scenarios section was ripped right from your gist and updated. I know you've had the goal for a long time of getting that into the doc itself. I meant to call that out with credit to you in the original PR ...

Yes, the table is nice (and yes, a lot of work), and hopefully we can keep it up to date if and when the startup changes in the future.

@fdncred
Copy link
Contributor

fdncred commented Dec 4, 2024

are we ready to land this? i figure since it says "preview" we can land it before the release.

@NotTheDr01ds
Copy link
Contributor Author

@fdncred Yes, ready to land. I'll continue to update it as we get feedback, and (if not already) it should be solid by the time 0.101 releases.

Thanks!

@fdncred fdncred merged commit 76c273a into nushell:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants